Skip to content

Add a count to Copen to set quickfix height#207

Open
shym wants to merge 1 commit into
tpope:masterfrom
shym:copen-count
Open

Add a count to Copen to set quickfix height#207
shym wants to merge 1 commit into
tpope:masterfrom
shym:copen-count

Conversation

@shym

@shym shym commented Jul 22, 2017

Copy link
Copy Markdown
Contributor

Proposal of a PR to close #177.
If you agree with this solution, I could mention the option in the documentation.

@tpope

tpope commented Jul 26, 2017

Copy link
Copy Markdown
Owner

I don't think I'm on board with the whole dispatch_temporary_quickfix_height shenanigans.

@shym

shym commented Aug 3, 2017

Copy link
Copy Markdown
Contributor Author

Thinking about it, I’m not so sure either.
So I rewrote this PR to what I originally had in mind, when I opened #177.
This does change a current behaviour for users who set dispatch_quickfix_height and expect Copen to use this value, but this makes it closer to copen, using 10 lines unless you explicitly mention the height.

@shym

shym commented Oct 25, 2017

Copy link
Copy Markdown
Contributor Author

@tpope did you have time to look that PR again?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a height option to Copen

2 participants